fix(NODE-4639): allow PromiseProvider to be null #3412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
added
the
Primary Review
…et and allow clearing with null
nbbeeken
force-pushed
the
NODE-4639/promise-provider
branch
from
047f5ef
to
bf7a32a
Compare
baileympearson
approved these changes
Sep 14, 2022
baileympearson
added
Team Review
baileympearson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PromiseProvider fix from #3406
What is changing?
What is the motivation for this change?
The promise provider could have always returned a nullish value, the types were casting away the potential issue. This corrects the issue and allows the PromiseProvider to be unset with
nullDouble check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>