feat(NODE-4634): add support for bulk FindOperators.hint() #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and fix `.update()`/`.updateOne()` to also accept pipeline-style updates as other update APIs do as well.
nbbeeken
reviewed
Sep 13, 2022
nbbeeken
added
the
Primary Review
nbbeeken
added
Team Review
nbbeeken
approved these changes
Sep 13, 2022
baileympearson
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
FindOperators.update()and.updateOne()use updated TS definitions to allow pipeline-style updates (which are supported by the server and by the actual implementation itself)FindOperators.hint()is added as an analogue to the.collation(),.arrayHints()and.upsert()methodsIs there new documentation needed for these changes?
I would assume so.
What is the motivation for this change?
mongosh cannot implement
.hint()in its own bulk write builder API without one of:collection.bulkWrite(), orDouble check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>