refactor(NODE-4617): use promise apis in benchmarks #3399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-4617-benchmarks-use-promises
branch
from
d33de25
to
ae6dde1
Compare
baileympearson
force-pushed
the
NODE-4617-benchmarks-use-promises
branch
from
ae6dde1
to
16efe60
Compare
baileympearson
commented
Sep 8, 2022
nbbeeken
requested changes
Sep 12, 2022
nbbeeken
added
the
Primary Review
nbbeeken
requested changes
Sep 12, 2022
| @@ -96,6 +97,23 @@ class Benchmark { | |||
| return this; | |||
| } | |||
|
|
|||
| /** | |||
| * Sets the task type - either a synchronous or asynchronous task. The default is async. | |||
There was a problem hiding this comment.
Suggested change
| * Sets the task type - either a synchronous or asynchronous task. The default is async. | |
| * Sets the task type - either a synchronous or asynchronous task. The default is async. |
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
nbbeeken
added
Team Review
dariakp
requested changes
Sep 13, 2022
dariakp
approved these changes
Sep 14, 2022
nbbeeken
approved these changes
Sep 15, 2022
nbbeeken
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Our benchmarks now test the promise-based API instead of the callback based api.
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
We should benchmark the API we plan to support.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>