Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-4583): revert nested union type support #3383

Merged
merged 2 commits into from Aug 25, 2022
Merged

fix(NODE-4583): revert nested union type support #3383

merged 2 commits into from Aug 25, 2022

Conversation

durran
Copy link
Member

@durran durran commented Aug 25, 2022

Description

Reverts the strict nested union types support.

What is changing?

Reverts #3349 and comments out the added test with link to original ticket.

Reopens NODE-4513

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-4583 / NODE-4571

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran changed the title Node 4571 fix(NODE-4571): revert nested union type support Aug 25, 2022
@durran durran marked this pull request as ready for review August 25, 2022 17:22
@durran
Copy link
Member Author

durran commented Aug 25, 2022

Failures on latest: https://jira.mongodb.org/browse/SERVER-69146

@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 25, 2022
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 25, 2022
@dariakp dariakp changed the title fix(NODE-4571): revert nested union type support fix(NODE-4583): revert nested union type support Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
3 participants