Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4548): export ChangeStream class from top-level #3357

Merged
merged 5 commits into from Aug 18, 2022
Merged

feat(NODE-4548): export ChangeStream class from top-level #3357

merged 5 commits into from Aug 18, 2022

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Aug 15, 2022 •
edited by dariakp

Description

What is changing?

NODE-4548
We need to make ChangeStream accessible

(Also cleaned up inconsistent naming in deprecated APIs)

What is the motivation for this change?

Backwards compat.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the NODE-4520/add-legacy-callback-client-literal branch 5 times, most recently from 33b6624 to 070b607 Compare August 16, 2022 15:48
@nbbeeken nbbeeken marked this pull request as ready for review August 16, 2022 18:05
@nbbeeken nbbeeken changed the title feat(NODE-4520): deprecate callback support and implement wrapper library fix(NODE-4520): export ChangeStream and save userOptions for client for legacy wrapper Aug 16, 2022
@nbbeeken nbbeeken changed the title fix(NODE-4520): export ChangeStream and save userOptions for client for legacy wrapper fix(NODE-4548): export ChangeStream and save userOptions for client for legacy wrapper Aug 16, 2022
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 17, 2022
dariakp
dariakp requested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why the raw user options need to be exposed? (Also, this is more of a "feat" because of the change stream class being newly exposed)

@nbbeeken nbbeeken requested a review from dariakp August 17, 2022 17:21
@nbbeeken nbbeeken changed the title fix(NODE-4548): export ChangeStream and save userOptions for client for legacy wrapper fix(NODE-4548): export ChangeStream class from top-level Aug 17, 2022
baileympearson
baileympearson requested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a feat like Daria mentioned, and can we update the ticket description as well to reflect that you no longer are exporting the user options?

@nbbeeken nbbeeken changed the title fix(NODE-4548): export ChangeStream class from top-level feat(NODE-4548): export ChangeStream class from top-level Aug 17, 2022
baileympearson
baileympearson previously approved these changes Aug 17, 2022
View reviewed changes
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 17, 2022
@baileympearson baileympearson dismissed their stale review August 17, 2022 19:37

wasn't ready for team review

@dariakp dariakp added Primary Review In Review with primary reviewer, not yet ready for team's eyes and removed Team Review Needs review from team labels Aug 17, 2022
@nbbeeken nbbeeken force-pushed the NODE-4520/add-legacy-callback-client-literal branch from 485e4fe to 4ba9e2d Compare August 17, 2022 19:48
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 17, 2022
dariakp
dariakp approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the use in the legacy client, here: mongodb-js/nodejs-mongodb-legacy#1 so this should be ready to go

durran
durran reviewed Aug 18, 2022
View reviewed changes
src/collection.ts
@@ -1610,13 +1610,13 @@ export class Collection<TSchema extends Document = Document> {
* Updates documents.
*
* @deprecated use updateOne, updateMany or bulkWrite
* @param selector - The selector for the update operation.
* @param filter - The filter for the update operation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing these to our spec language.

@dariakp dariakp merged commit 48f295a into main Aug 18, 2022
@dariakp dariakp deleted the NODE-4520/add-legacy-callback-client-literal branch August 18, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@dariakp dariakp dariakp approved these changes

@baileympearson baileympearson baileympearson left review comments

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
4 participants
@nbbeeken @durran @baileympearson @dariakp