Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-4159,NODE-4512): remove servers with incorrect setName from topology and fix unix socket parsing #3348

Merged
merged 9 commits into from Aug 10, 2022
Merged

fix(NODE-4159,NODE-4512): remove servers with incorrect setName from topology and fix unix socket parsing #3348

merged 9 commits into from Aug 10, 2022

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Aug 5, 2022 •
edited by dariakp

Description

What is changing?

What is the motivation for this change?

Aligns with spec test, easier assertion against unit specs

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 9, 2022
@nbbeeken nbbeeken force-pushed the NODE-4159/sdam-remove-servers branch from 9801ad1 to 307d307 Compare August 9, 2022 15:57
@nbbeeken nbbeeken marked this pull request as ready for review August 9, 2022 15:57
@nbbeeken nbbeeken requested a review from dariakp August 9, 2022 15:57
dariakp
dariakp requested changes Aug 9, 2022
View reviewed changes
test/unit/utils.test.ts Outdated Show resolved Hide resolved
test/unit/utils.test.ts Outdated Show resolved Hide resolved
test/unit/assorted/server_discovery_and_monitoring.spec.test.ts Outdated Show resolved Hide resolved
test/unit/assorted/server_discovery_and_monitoring.spec.test.ts Outdated Show resolved Hide resolved
test/unit/assorted/server_discovery_and_monitoring.spec.test.ts Outdated Show resolved Hide resolved
test/unit/operations/find.test.ts Show resolved Hide resolved
@dariakp dariakp changed the title fix(NODE-4159): remove servers with incorrect setName from topology fix(NODE-4159,NODE-4512): remove servers with incorrect setName from topology Aug 9, 2022
@dariakp dariakp changed the title fix(NODE-4159,NODE-4512): remove servers with incorrect setName from topology fix(NODE-4159,NODE-4512): remove servers with incorrect setName from topology and fix socket parsing Aug 9, 2022
@nbbeeken nbbeeken changed the title fix(NODE-4159,NODE-4512): remove servers with incorrect setName from topology and fix socket parsing fix(NODE-4159,NODE-4512): remove servers with incorrect setName from topology and fix unix socket parsing Aug 9, 2022
@nbbeeken nbbeeken requested a review from dariakp August 9, 2022 21:05
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 10, 2022
@baileympearson baileympearson merged commit 00dcf2d into main Aug 10, 2022
@baileympearson baileympearson deleted the NODE-4159/sdam-remove-servers branch August 10, 2022 17:39
@nbbeeken nbbeeken mentioned this pull request Aug 12, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@baileympearson baileympearson baileympearson approved these changes

@dariakp dariakp dariakp approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
4 participants
@nbbeeken @durran @baileympearson @dariakp