Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4336): deprecate old write concern options and add missing writeConcern to MongoClientOptions #3340

Merged
merged 1 commit into from Jul 29, 2022
Merged

feat(NODE-4336): deprecate old write concern options and add missing writeConcern to MongoClientOptions #3340

merged 1 commit into from Jul 29, 2022

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jul 28, 2022 •
edited by dariakp

Description

What is changing?

  • Added writeConcern to MongoClientOptions
  • Added deprecation flags to the top level versions of the options
  • Added a type test

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 28, 2022
@dariakp dariakp self-assigned this Jul 28, 2022
dariakp
dariakp reviewed Jul 28, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, but I think we should use feat, because we are updating the deprecation markers in the docs; I think the title should be something like feat(NODE-4336): deprecate old write concern options and add missing writeConcern to MongoClientOptions

@nbbeeken nbbeeken changed the title fix(NODE-4336): fix writeConcern missing from MongoClientOptions feat(NODE-4336): deprecate old write concern options and add missing writeConcern to MongoClientOptions Jul 28, 2022
@nbbeeken
Copy link
Contributor Author

Alright yea, fair enough better to call it out then it perhaps get overlooked in a sub bullet

@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jul 28, 2022
dariakp
dariakp approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending CI

@baileympearson baileympearson merged commit d2b6ad8 into main Jul 29, 2022
@baileympearson baileympearson deleted the NODE-4336/writeConcernOnClient branch July 29, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@dariakp dariakp dariakp approved these changes

Assignees

@dariakp dariakp

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
4 participants
@nbbeeken @durran @dariakp @baileympearson