fix(NODE-4273): pass 'comment' option through to distinct command #3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
reviewed
Jul 28, 2022
baileympearson
force-pushed
the
NODE-4273
branch
2 times, most recently
from
ed2cfa3
to
98345f3
Compare
nbbeeken
previously approved these changes
Aug 1, 2022
|
Changes LGTM, CI should be fixed with a rebase we think. |
baileympearson
force-pushed
the
NODE-4273
branch
from
98345f3
to
b0cabc5
Compare
baileympearson
added
the
Primary Review
nbbeeken
previously approved these changes
Aug 2, 2022
nbbeeken
added
Team Review
dariakp
requested changes
Aug 2, 2022
test/integration/node-specific/comment_with_falsy_values.test.ts
Outdated
Show resolved
Hide resolved
dariakp
requested changes
Aug 2, 2022
dariakp
approved these changes
Aug 3, 2022
nbbeeken
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
The
commentoption is now attached to thedistinctcommand.Is there new documentation needed for these changes?
No.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>