fix(NODE-3513): default command monitoring to off #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
added
the
Primary Review
dariakp
requested changes
Aug 2, 2021
There was a problem hiding this comment.
Can we also add a sanity test to make sure we can set monitorCommands to true? I also don't see it in this file as part of allURIOptions, but I think it's allowed, so we should probably add a test for setting it both ways.
It looks like there are some tests failing in evergreen with "Cannot read property 'command' of undefined", so they may have been relying on command monitoring being turned on by default
dariakp
approved these changes
Aug 2, 2021
dariakp
added
Team Review
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert an accidental default enabling of command monitoring