feat(NODE-2843): implement sessions advanceClusterTime method #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
reviewed
Jul 28, 2021
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
dariakp
added
Primary Review
dariakp
added
Team Review
dariakp
commented
Jul 30, 2021
| !clusterTime.signature || | ||
| clusterTime.signature.hash?._bsontype !== 'Binary' || | ||
| (typeof clusterTime.signature.keyId !== 'number' && | ||
| clusterTime.signature.keyId?._bsontype !== 'Long') // apparently we decode the key to number? |
There was a problem hiding this comment.
@nbbeeken Just bringing your attention to this change
There was a problem hiding this comment.
Just so I do not block this PR: looks correct to me.
Remind me to tell you the deeper issue here / file a ticket next week, has to do with BSON promote* options I think.
durran
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-2843
What changed?
Implemented the advanceClusterTime session method, refactored internal helper function for naming consistency