Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-3199): unable to bundle driver due to uncaught require #2904

Merged
merged 2 commits into from Jul 20, 2021

Conversation

nbbeeken
Copy link
Contributor

Forward port of #2903, includes fix relating to mongodb-js/mongodb-connection-string-url#2

@emadum emadum self-requested a review July 16, 2021 16:30
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 19, 2021
@emadum emadum added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jul 19, 2021
@emadum emadum requested review from dariakp and durran July 19, 2021 16:18
@emadum emadum marked this pull request as ready for review July 19, 2021 16:19
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emadum emadum merged commit 9e48bbd into 4.0 Jul 20, 2021
@emadum emadum deleted the NODE-3199/4.0/trycatch-deps branch July 20, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
3 participants