fix(NODE-3109): prevent servername from being IP #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-3109/no-ip-in-sni
branch
from
3736bf1
to
c9ca8e7
Compare
servername should only ever be a hostname. Add a condition to check if the host is an IP and skip auto setting the servername.
nbbeeken
force-pushed
the
NODE-3109/no-ip-in-sni
branch
from
c9ca8e7
to
def14d6
Compare
emadum
approved these changes
Mar 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
servername should only ever be a hostname. Add a condition
to check if the host is an IP and skip auto setting the servername.