NODE-3008: Adding test for cursor cloning removing session #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
changed the title
durran
force-pushed
the
NODE-3008/clone-cursor-removes-session
branch
from
8417d08
to
b0bf9b4
Compare
emadum
suggested changes
Jan 29, 2021
Comment on lines
+4689
to
+4691
| expect(clonedCursor.cursorState.session).to.not.exist; | ||
| cursor.close(); | ||
| done(); |
There was a problem hiding this comment.
Suggested change
| expect(clonedCursor.cursorState.session).to.not.exist; | |
| cursor.close(); | |
| done(); | |
| expect(clonedCursor.cursorState).to.not.have.property('session'); | |
| cursor.close(done); |
There was a problem hiding this comment.
Yeah I already fixed it and force pushed. ;)
emadum
approved these changes
Feb 1, 2021
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test to ensure that cloning a cursor removes the session from the new cursor.