NODE-2355: Allow GridFS write stream to destroy #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Jan 15, 2021
durran
force-pushed
the
NODE-2355/gridfs-write-streams
branch
from
f7f7abe
to
594ef3b
Compare
durran
force-pushed
the
NODE-2355/gridfs-write-streams
branch
from
594ef3b
to
eb8e8ac
Compare
emadum
suggested changes
Jan 15, 2021
|
@emadum Sorry about that - I was just being consistent with the tests currently in that file. Would you be ok with leaving this PR as is (so it's just the relevant changes) and opening a new PR that refactors all the tests in that file to the new style? That way this PR doesn't get cluttered with refactorings. |
nbbeeken
approved these changes
Jan 19, 2021
SGTM! 👍 |
emadum
approved these changes
Jan 19, 2021
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
GridFSBucketWriteStreamneeds to invoke theWritableconstructor, not just inherit from it, in order to properly initialise the internal state of the stream. This allows the stream to be destroyed properly.