fix: Change socket timeout default to 0 [PORT] #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
commented
Oct 12, 2020
Comment on lines
100
to
112
| it('should default socketTimeout to infinity', function(done) { | ||
| const client = new MongoClient(this.configuration.url()); | ||
| client.connect(() => { | ||
| expect(client.s.options.socketTimeoutMS).to.deep.equal(0); | ||
| for (const connection of client.topology.s.coreTopology.connections()) { | ||
| expect(connection.socketTimeout).to.deep.equal(0); | ||
| } | ||
| done(); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
@mbroadst I saw your comment about missing testing on the 4.0 version of this, added a test here that I'll also add to 4.0 if this is all good ✅
mbroadst
approved these changes
Oct 14, 2020
Comment on lines
100
to
112
| it('should default socketTimeout to infinity', function(done) { | ||
| const client = new MongoClient(this.configuration.url()); | ||
| client.connect(() => { | ||
| expect(client.s.options.socketTimeoutMS).to.deep.equal(0); | ||
| for (const connection of client.topology.s.coreTopology.connections()) { | ||
| expect(connection.socketTimeout).to.deep.equal(0); | ||
| } | ||
| done(); | ||
| }); | ||
| }); | ||
|
|
emadum
approved these changes
Oct 15, 2020
nbbeeken
force-pushed
the
NODE-2835/remove-default-read-timeout
branch
from
4c2af4e
to
5cef410
Compare
mbroadst
suggested changes
Nov 5, 2020
| @@ -799,7 +799,7 @@ describe('Collection', function() { | |||
|
|
|||
| db.listCollections().toArray((err, documents) => { | |||
| expect(err).to.not.exist; | |||
| expect(documents.length > 1).to.be.true; | |||
| expect(documents.length >= 1).to.be.true; | |||
There was a problem hiding this comment.
This test fails if you run it in isolation, it depends upon other tests to create multiple collections when it only creates one itself.
Socket timeout by default is infinity. NODE-2835
nbbeeken
force-pushed
the
NODE-2835/remove-default-read-timeout
branch
from
5e3fc3c
to
a0d94cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Socket timeout by default is infinity.
NODE-2835