Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NODE-2474: update equal server description #2260

Merged
merged 4 commits into from Mar 11, 2020

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Mar 10, 2020

Description

NODE-2474 - Server_Description update with lastUpdateTime / lastWriteDate fields is ignored in topology

The SDAM spec says:

Each time the client checks a server, it MUST replace its description of that server with a new one. This replacement MUST happen even if the new server description compares equal to the previous one, in order to keep client-tracked attributes like last update time and round trip time up to date.

This PR ensures the server description is updated even when equal.

What changed?

Are there any files to ignore?

Copy link
Contributor

@reggi reggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@emadum emadum merged commit 0c36a32 into 3.5 Mar 11, 2020
@emadum emadum deleted the NODE-2474/update-equal-server-description-3.5 branch March 11, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants