MOTOR-843 Add support for the comment field to all helpers #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing that could be added is unit tests for the docstrings, similar to my "comment" field PR: https://github.com/juliusgeo/mongo-python-driver/blob/5160ae8da3e802baae44e2a0a5bb84e346cd67be/test/test_comment.py on line 71. |
|
We had to skip that test in #158 because it is checking the signature, and we would have had to update all of the signatures in Motor to be explicit instead of using args and kwargs. |
juliusgeo
reviewed
Apr 22, 2022
motor/docstrings.py
Outdated
| @@ -662,6 +696,9 @@ async def create_x_index(): | |||
| {'_id_': {'key': [('_id', 1)]}, | |||
| 'x_1': {'unique': True, 'key': [('x', 1)]}} | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I think this blank line should be placed below.
ShaneHarvey
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these were added as part of #158