MOTOR-784 Versioned API migration example for ecosystem docs #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Jul 22, 2021
test/asyncio_tests/test_examples.py
Outdated
| "raise an exception") | ||
|
|
||
| # Start Versioned API Example 6 | ||
| # pymongo.errors.OperationFailure: Provided apiStrict:true, but the command count is not in API Version 1, full error: {'ok': 0.0, 'errmsg': 'Provided apiStrict:true, but the command count is not in API Version 1', 'code': 323, 'codeName': 'APIStrictError', '$clusterTime': {'clusterTime': Timestamp(1626977595, 10), 'signature': {'hash': b'\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00', 'keyId': 0}}, 'operationTime': Timestamp(1626977595, 10)} |
test/asyncio_tests/test_examples.py
Outdated
|
|
||
| # Start Versioned API Example 7 | ||
| await client.db.sales.aggregate( | ||
| [{"$group": {"_id": None, "count": {"$count": {}}}}]).to_list(length=None) |
There was a problem hiding this comment.
This should really be using count_documents() or estimated_document_count() instead of aggregate . I asked about it on the drivers ticket https://jira.mongodb.org/browse/DRIVERS-1846
test/asyncio_tests/test_examples.py
Outdated
| {"_id": 5, "item": "xyz", "price": 5, "quantity": 10, "date": datetime.datetime.strptime("2021-02-15T09:05:00Z", "%Y-%m-%dT%H:%M:%SZ")}, | ||
| {"_id": 6, "item": "xyz", "price": 5, "quantity": 5, "date": datetime.datetime.strptime("2021-02-15T12:05:10Z", "%Y-%m-%dT%H:%M:%SZ")}, | ||
| {"_id": 7, "item": "xyz", "price": 5, "quantity": 10, "date": datetime.datetime.strptime("2021-02-15T14:12:12Z", "%Y-%m-%dT%H:%M:%SZ")}, | ||
| {"_id": 8, "item": "abc", "price": 10, "quantity": 5, "date": datetime.datetime.strptime("2021-03-16T20:20:13Z", "%Y-%m-%dT%H:%M:%SZ")} |
There was a problem hiding this comment.
Suggest refactoring to make this less verbose. Maybe:
def strptime(s):
return datetime.datetime.strptime(s, "%Y-%m-%dT%H:%M:%SZ")
...
await client.db.sales.insert_many([
{"_id": 1, "item": "abc", "price": 10, "quantity": 2, "date": strptime("2021-01-01T08:00:00Z")},
ShaneHarvey
reviewed
Jul 22, 2021
ShaneHarvey
reviewed
Jul 22, 2021
There was a problem hiding this comment.
I think we should wait until the countDocuments idea is clarified in DRIVERS-1846 before merging this. We don't need to hold up 2.5 for this change.
|
@ShaneHarvey discussion on the DRIVERS ticket seems to have wrapped up. I've updated this PR to reflect the new example. |
ShaneHarvey
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a weird one. Somehow we are supposed to show the output of running some commands as part of the example. I am not really sure how to do that...