MOTOR-735 Versioned API connection examples for ecosystem docs #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantmital
commented
Jul 22, 2021
| @@ -30,7 +30,7 @@ | |||
| with open("README.rst") as readme: | |||
| long_description = readme.read() | |||
|
|
|||
| pymongo_ver = ">=3.11,<4" | |||
| pymongo_ver = ">=3.12,<4" | |||
There was a problem hiding this comment.
Needed to bump this here since 3.11 doesn't have pymongo.server_api. One less ticket!
There was a problem hiding this comment.
Great. Can you link MOTOR-699 in the commit message?
There was a problem hiding this comment.
Will do! Thanks for pulling up the ticket.
| def test_versioned_api(self): | ||
| # Versioned API examples | ||
| AsyncIOMotorClient = lambda _, server_api: self.asyncio_client( | ||
| server_api=server_api, connect=False) |
There was a problem hiding this comment.
I wrote this to mimic the PyMongo PR - mongodb/mongo-python-driver@048f54d
But I have no idea why we set connect=False? Can we remove it?
There was a problem hiding this comment.
It's to reduce the overhead of the test. Since the test doesn't need to actually use the MongoClient there's no point in starting all the monitor threads. Let's keep it and add a comment.
ShaneHarvey
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.