PYTHON-2608 Fix KMS TLS testing on Python <3.5 #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
force-pushed
the
PYTHON-2608-fix-3.12
branch
from
1db5240
to
33ab3ed
Compare
prashantmital
suggested changes
Jul 12, 2021
| pushd ${DRIVERS_TOOLS}/.evergreen/csfle | ||
| python -u lib/kms_http_server.py --ca_file ../x509gen/ca.pem --cert_file ../x509gen/expired.pem --port 8000 & | ||
| python -u lib/kms_http_server.py --ca_file ../x509gen/ca.pem --cert_file ../x509gen/wrong-host.pem --port 8001 & | ||
| trap 'kill $(jobs -p)' EXIT HUP | ||
| popd | ||
| # Restore the test virtualenv. | ||
| if [ $IS_PRE_35 = "1" ]; then |
There was a problem hiding this comment.
Can we add an activatevritualenv function to utils.sh and just call that from both createvirtualenv and also here? It'll be much cleaner.
prashantmital
approved these changes
Jul 12, 2021
This reverts commit 71ff441.
|
I had to revert the activatevritualenv change because it doesn't work. After that change the tests no longer ran in the venv where pymongocrypt was installed and all the encrypt tests were skipped: Not sure what exactly the issue was but it's simpler to revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I backported PYTHON-2608 I didn't realize that the mock KMS script requires Python 3.5+. For <3.5 we need to create yet another virtualenv. This fixes the encryption tests on v3.12.