PYTHON-2608 Test that KMS TLS connections verify peer certificates #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantmital
suggested changes
Jul 9, 2021
.evergreen/config.yml
Outdated
| @@ -361,6 +361,32 @@ functions: | |||
| PYTHON_BINARY=${PYTHON_BINARY} sh ${PROJECT_DIRECTORY}/.evergreen/run-doctests.sh | |||
|
|
|||
| "run tests": | |||
| # If testing encryption start the mock KMS servers. | |||
| # First create the virtualenv and install dependencies. | |||
| - command: shell.exec | |||
There was a problem hiding this comment.
Instead of doing this here, can't we do this in run-tests.sh gated under a check on TEST_ENCRYPTION? In config.yml under "run tests" we seem to limit ourselves to setting up environment variables which then get used by run-tests.sh. It'll be nice to stick to that...
There was a problem hiding this comment.
Done. That's way simpler.
This reverts commit 01d7367.
|
Updated to start the mock KMS servers in run-test.sh. I also moved all our scripts to bash instead of sh. The remaining windows failures are due to PYTHON-2798. |
prashantmital
approved these changes
Jul 9, 2021
ShaneHarvey
added a commit
to ShaneHarvey/mongo-python-driver
that referenced
this pull request
Jul 9, 2021
…ongodb#667) Use bash for all evergreen scripts. (cherry picked from commit 834500d)
ShaneHarvey
added a commit
that referenced
this pull request
Jul 9, 2021
) Use bash for all evergreen scripts. (cherry picked from commit 834500d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the tests described here: https://github.com/mongodb/specifications/tree/master/source/client-side-encryption/tests#kms-tls-tests
Patch (Note the Windows failures are unrelated see PYTHON-2798): https://spruce.mongodb.com/version/60e643e47742ae7acd922fe3/tasks