Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON-3526 Fix mockup tests #1119

Merged
merged 1 commit into from Nov 17, 2022
Merged

PYTHON-3526 Fix mockup tests #1119

merged 1 commit into from Nov 17, 2022

Conversation

ShaneHarvey
Copy link
Member

No description provided.

@ShaneHarvey
Copy link
Member Author

Originally we discussed adding test/mockupdb/__init__.py to fix this issue but we can't do that otherwise unittest will start running these tests by default. Instead I decided to just ignore the mypy error.

blink1073
blink1073 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ShaneHarvey ShaneHarvey merged commit b290f7b into mongodb:master Nov 17, 2022
@ShaneHarvey ShaneHarvey deleted the PYTHON-3526 branch November 18, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

@juliusgeo juliusgeo Awaiting requested review from juliusgeo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ShaneHarvey @blink1073