Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON-3527 + PYTHON-3528 Fix no-server tests #1118

Merged
merged 3 commits into from Nov 17, 2022
Merged

PYTHON-3527 + PYTHON-3528 Fix no-server tests #1118

merged 3 commits into from Nov 17, 2022
+24 −11

Conversation

ShaneHarvey
Copy link
Member

PYTHON-3528 Skip TestCreateEntities when no server is running.
PYTHON-3527 Skip test_typeddict_find_notrequired when no server is running.

Also fixes the 150s TestCreateEntities issue.

@ShaneHarvey ShaneHarvey marked this pull request as ready for review November 17, 2022 18:36
blink1073
blink1073 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ShaneHarvey ShaneHarvey merged commit cde9adf into mongodb:master Nov 17, 2022
@ShaneHarvey ShaneHarvey deleted the PYTHON-3528 branch November 18, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

@juliusgeo juliusgeo Awaiting requested review from juliusgeo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ShaneHarvey @blink1073