Add top-level error labels to write concern error #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow the driver to properly retry writes that the server has labeled as a RetryableWriteError. JAVA-4244
jyemin
commented
Jul 26, 2021
| @@ -264,7 +265,9 @@ public static MongoException createSpecialException(final BsonDocument response, | |||
| } else if (isNotPrimaryError(errorCode, errorMessage)) { | |||
| return new MongoNotPrimaryException(response, serverAddress); | |||
| } else if (response.containsKey("writeConcernError")) { | |||
| return createSpecialException(response.getDocument("writeConcernError"), serverAddress, "errmsg"); | |||
| return createSpecialException(response.getDocument("writeConcernError").clone() | |||
There was a problem hiding this comment.
It's pretty hacky to clone the writeConcernError document so we can append errorLabels to it, but it's the most localized fix. Happy to entertain other ideas though
| import java.net.URISyntaxException; | ||
| import java.util.Collection; | ||
|
|
||
| public class UnifiedRetryableWritesTest extends UnifiedReactiveStreamsTest { |
There was a problem hiding this comment.
These are the first unified retryable writes tests so need new runners for them.
| @@ -0,0 +1,205 @@ | |||
| { | |||
There was a problem hiding this comment.
I added these two new unified tests for this, in scope of already existing DRIVERS-1385 ticket.
|
Sharded tests are failing... Converting to draft while investigation is in progress. |
rozza
requested changes
Jul 27, 2021
| @@ -264,7 +265,16 @@ public static MongoException createSpecialException(final BsonDocument response, | |||
| } else if (isNotPrimaryError(errorCode, errorMessage)) { | |||
| return new MongoNotPrimaryException(response, serverAddress); | |||
| } else if (response.containsKey("writeConcernError")) { | |||
| return createSpecialException(response.getDocument("writeConcernError"), serverAddress, "errmsg"); | |||
| BsonDocument writeConcernError = response.getDocument("writeConcernError"); | |||
There was a problem hiding this comment.
I think this is more complex than it needs to be:
MongoException error = createSpecialException(response.getDocument("writeConcernError"), serverAddress, "errmsg");
for (BsonValue errorLabel : response.getArray("errorLabels", new BsonArray())) {
error.addLabel(errorLabel.asString().getValue());
}
return error;
There was a problem hiding this comment.
That's so much better. Thanks. Added a couple of checks to a conditional protecting the loop. One is necessary for correctness, the other just to document intent.
Done.
jyemin
added a commit
to jyemin/mongo-java-driver
that referenced
this pull request
Jul 27, 2021
This will allow the driver to properly retry writes that the server has labeled as a RetryableWriteError. JAVA-4244
jyemin
added a commit
to jyemin/mongo-java-driver
that referenced
this pull request
Jul 27, 2021
This will allow the driver to properly retry writes that the server has labeled as a RetryableWriteError. JAVA-4244
ispringer
pushed a commit
to evergage/mongo-java-driver
that referenced
this pull request
May 16, 2023
This will allow the driver to properly retry writes that the server has labeled as a RetryableWriteError. JAVA-4244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the driver to properly retry writes that the server
has labeled as a RetryableWriteError.
JAVA-4244