Ensure write error is included in exception message #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement new CRUD specification prose test for write error details JAVA-3993
jyemin
commented
Jun 3, 2021
| import static org.junit.Assert.assertTrue; | ||
| import static org.junit.Assert.fail; | ||
| import static org.junit.Assume.assumeTrue; | ||
|
|
||
| // See https://github.com/mongodb/specifications/tree/master/source/change-streams/tests/README.rst#prose-tests |
There was a problem hiding this comment.
This comment was copy pasta-d from elsewhere.
| /** | ||
| * See https://github.com/mongodb/specifications/blob/master/source/crud/tests/README.rst#prose-tests | ||
| */ | ||
| public class CrudProseTest extends DatabaseTestCase { |
There was a problem hiding this comment.
Renamed class to indicate the spec from which the prose tests came
| @@ -33,7 +33,7 @@ | |||
| * @param serverAddress the server address | |||
| */ | |||
| public MongoWriteException(final WriteError error, final ServerAddress serverAddress) { | |||
| super(error.getCode(), error.getMessage(), serverAddress); | |||
| super("Write operation error on server " + serverAddress + ". Write error: " + error + ". ", serverAddress); | |||
There was a problem hiding this comment.
Ensures that the whole write error, including details, will show up as part of the exception message. This matches the behavior of MongoBulkWriteException.
|
Converted to draft as tests are failing. |
stIncMale
reviewed
Jun 3, 2021
stIncMale
approved these changes
Jun 8, 2021
jyemin
added a commit
to jyemin/mongo-java-driver
that referenced
this pull request
Jun 8, 2021
Implement new CRUD specification prose test for write error details JAVA-3993
ispringer
pushed a commit
to evergage/mongo-java-driver
that referenced
this pull request
May 16, 2023
Implement new CRUD specification prose test for write error details JAVA-3993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement new CRUD specification prose test for write error details
JAVA-3993