GODRIVER-2305 Correctly append empty TagSet #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Feb 17, 2022
benjirewis
added a commit
that referenced
this pull request
Feb 17, 2022
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2305
GODRIVER-1078 previously "fixed" behavior for empty tag sets provided in the URI (
readPreferenceTags=) to simply skip instead of error. In reality,readPreferenceTags=in the URI represents a wild-card that should match any server with any tags (see docs here).Appends
map[string]string{}to tag sets ifreadPreferenceTags=is encountered. Fixes associated tests inconnstring_test.go.