GODRIVER-2292 Support dedicated load balancer port in tests. #852
Conversation
matthewdale
force-pushed
the
godriver2292-add-lb-port
branch
7 times, most recently
from
76f6ddf
to
e1e1996
Compare
.evergreen/config.yml
Outdated
| # The new "loadBalancerPort" option is supported starting with server 5.2, which responds | ||
| # correctly to "hello" commands with a service ID when behind a load balancer. Only run load | ||
| # balancer tests on server 5.2+. | ||
| # TODO(GODRIVER-2292): Add version "5.2" when it's available on Evergreen. |
There was a problem hiding this comment.
You may be able to remove this TODO. Alternatively, add rapid to the version list.
From this slack conversation I interpret the intent to be that drivers to test against the following set of server versions:
- Supported major releases (for Go:
2.6,3.0,3.4,3.6,4.0,4.2,4.4,5.0) - The latest build from evergreen (e.g.
5.3.0-alpha...) - The latest rapid release (currently
5.2only, not5.1).
There was a problem hiding this comment.
I agree. It sounds like ideally we'd want all Evergreen tasks that test against latest to probably also test against rapid. You could separate that work into another ticket and leave a relevant TODO here if that seems overboard for this PR.
There was a problem hiding this comment.
Ah, I didn't know that existed. It's weird that "rapid" refers to version 5.2, but using the literal version string "5.2" results in a configuration error. At any rate, that sounds like a good change, so I'll add "rapid" to the list.
I'll also create a ticket to update all tasks that use "latest" to also use "rapid".
There was a problem hiding this comment.
Created ticket GODRIVER-2316 to add "rapid" version to test matrix.
.evergreen/config.yml
Outdated
| # The new "loadBalancerPort" option is supported starting with server 5.2, which responds | ||
| # correctly to "hello" commands with a service ID when behind a load balancer. Only run load | ||
| # balancer tests on server 5.2+. | ||
| # TODO(GODRIVER-2292): Add version "5.2" when it's available on Evergreen. |
There was a problem hiding this comment.
I agree. It sounds like ideally we'd want all Evergreen tasks that test against latest to probably also test against rapid. You could separate that work into another ticket and leave a relevant TODO here if that seems overboard for this PR.
| @@ -116,7 +125,7 @@ func runSeedlistDiscoveryTest(mt *mtest.T, file string) { | |||
| } | |||
| for _, host := range test.Hosts { | |||
| _, err := getServerByAddress(host, topo) | |||
| assert.Nil(mt, err, "did not find host %v", host) | |||
| assert.Nil(mt, err, "error finding host %q: %v", host, err) | |||
matthewdale
force-pushed
the
godriver2292-add-lb-port
branch
from
e1e1996
to
a575637
Compare
matthewdale
force-pushed
the
godriver2292-add-lb-port
branch
from
a575637
to
5559f77
Compare
GODRIVER-2292
DRIVERS-1983 updated the load balancer mongo-orchestration config to support the new "loadBalancerPort" server option which allows the server to act more correctly in load balancer tests, including returning a "serviceID" in "hello" responses. Update the test runner to pass the new
LOAD_BALANCER="true"option to mongo-orchestration and remove support for mocking "serviceID".Changes:
LOAD_BALANCER="true"and passLOAD_BALANCERvalue to mongo-orchestration.