GODRIVER-2300 remove example.com from CSFLE tests #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
LGTM thanks for the quick change. I've recently seen these prose tests fail in the Go driver, too, so it's good we're avoiding the 404s from example.com.
benjirewis
pushed a commit
that referenced
this pull request
Mar 1, 2022
* GODRIVER-2274 add numbers to CSFLE Custom Endpoint prose tests * GODRIVER-2300 remove example.com from CSFLE tests
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
* GODRIVER-2274 add numbers to CSFLE Custom Endpoint prose tests * GODRIVER-2300 remove example.com from CSFLE tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Background and Motivation
Signed AWS requests were frequently returning HTTP 404s in the C driver CSFLE prose tests. The 404s were unexpected and resulted in test failures. The test does not require successfully connecting to an endpoint. See DRIVERS-2191 for more information.