GODRIVER-2263 Load all certs in a PEM #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e or sslClientCertificateKeyFile options
kevinAlbs
approved these changes
Jan 18, 2022
benjirewis
approved these changes
Jan 18, 2022
|
Created DRIVERS-2038 to request this test be added to all drivers. |
matthewdale
approved these changes
Jan 24, 2022
kevinAlbs
pushed a commit
that referenced
this pull request
Jan 24, 2022
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/GODRIVER-2263
When using tlsCertificateKeyFile or sslClientCertificateKeyFile options,
ClientOptions.ApplyURI()only loads the final cert in the provided PEM file. This is undesired when a PEM contains multiple certs to be considered during a TLS hand shake. This PR attaches all certs and private keys found in the PEM and passes them totls.X509KeyPair()for consideration.