Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-2248 Use mock deployment for slow BulkWrite update test #827

Merged
merged 1 commit into from Jan 4, 2022
Merged

GODRIVER-2248 Use mock deployment for slow BulkWrite update test #827

merged 1 commit into from Jan 4, 2022

Conversation

benjirewis
Copy link
Contributor

GODRIVER-2248

TestCollection/bulk_write/update_with_batches was causing timeouts on most of our MacOS variants. This was because of the large (100050) amount of documents that needed to be deleted server-side after the test. As in GODRIVER-1858, I've used the mock deployment built into mtest to lower testing times (from about 1m to about .3s).

Copy link
Contributor Author

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've linked a number of MacOS variants to this PR's CI so we can verify that timeouts are mostly gone.

mongo/integration/collection_test.go Show resolved Hide resolved
@benjirewis benjirewis marked this pull request as ready for review December 14, 2021 20:25
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mongo/integration/collection_test.go Show resolved Hide resolved
@benjirewis benjirewis merged commit 384560d into mongodb:master Jan 4, 2022
@benjirewis benjirewis deleted the bulkwriteUpdateWithBatches.2248 branch January 4, 2022 16:04
faem pushed a commit to kubedb/mongo-go-driver that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants