GODRIVER-2243 Wrap write errors in IndexView.CreateMany #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was returning driver.ErrUnacknowledgedWrite when creating indexes with an unacknowledged WriteConcern. Wrap the error using processWriteError so we can return mongo.ErrUnacknowledgedWrite.
benjirewis
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
This change makes sense to me! Good catch. Thanks so much for your contribution, @reillywatson. Failing test is due to GODRIVER-2242.
| _, err := mt.Coll.Indexes().CreateOne(mtest.Background, mongo.IndexModel{Keys: bson.D{{"x", 1}}}) | ||
| if err != mongo.ErrUnacknowledgedWrite { | ||
| // Use a direct comparison rather than assert.Equal because assert.Equal will compare the error strings, | ||
| // so the assertion would succeed even if the error had not been wrapped. |
There was a problem hiding this comment.
Helpful comment, thank you!
benjirewis
pushed a commit
that referenced
this pull request
Dec 8, 2021
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was returning driver.ErrUnacknowledgedWrite when creating indexes with an unacknowledged WriteConcern.
Wrap the error using processWriteError so we can return mongo.ErrUnacknowledgedWrite.