New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GODRIVER-2237: Run KMS KMIP spec and prose tests in Evergreen #816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Evergreen is complaining about your config.yml
file being invalid; it's because of alignment issues. See my "suggested change" comments on how to fix that. Can you also reconfigure the associated patch to run KMS KMIP Ubuntu 18.04
so we can see that it succeeds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 🧑🔧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a typo fix.
e99970d
to
729b298
Compare
As discussed offline, let's first merge PR #812 once you're done addressing comments there, rebase this PR on master, and make sure that the new/updated client-side-encryption tests are skipped on every task besides |
SGTM. A possible way to do this is to set an environment variable in the Example with the for _, fileName := range jsonFilesInDir(t, path.Join(dataPath, encryptionSpecName)) {
t.Run(fileName, func(t *testing.T) {
+ if fileName == "kmipKMS.json" && "" == os.Getenv("KMS_MOCK_SERVERS_RUNNING") {
+ t.Skipf("Skipping test as KMS_MOCK_SERVERS_RUNNING is not set")
+ }
runSpecTestFile(t, encryptionSpecName, fileName)
})
} |
729b298
to
0c1a981
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM even more!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
GODRIVER-2237
Configures an Evergreen build variant to test the KMS KMIP spec and prose tests. Passes according to this patch.