GODRIVER-2222 Prevent removing valid servers when updating SRV hosts. #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdale
force-pushed
the
godriver2222-fix-srvmaxhosts
branch
from
d9d95cb
to
babf959
Compare
kevinAlbs
approved these changes
Nov 21, 2021
matthewdale
force-pushed
the
godriver2222-fix-srvmaxhosts
branch
from
dfe752d
to
30eeef1
Compare
|
All failing tests are due to DRIVERS-1991 or GODRIVER-2238. |
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2222
Currently, the driver may remove valid servers from a topology when updating the topology based on the SRV host records if
len(SRV hosts) > srvMaxHosts. Instead, when updating topology servers from SRV host records, wait until we've determined the added and removed hosts to limit the topology servers list tosrvMaxHosts.Also use
rand.Rand.Shuffleinstead of a custom shuffle implementation and re-enable the "SRVMaxHosts is less than number of hosts" test.