GODRIVER-1918 Check for zero length in readstring #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwysiu
approved these changes
Mar 17, 2021
|
In case anyone is curious, a BSON string can never have length 0. An empty string in BSON is represented as |
divjotarora
approved these changes
Mar 24, 2021
benjirewis
added a commit
that referenced
this pull request
Mar 24, 2021
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-1918
Adds a check for zero length strings in readstring to ensure that a malformed string such as
{0x0, 0x0, 0x0, 0x0}will not panic withStringValue()andStringValueOk().Adds two new tests to verify no panic in the case of zero-length strings.