GODRIVER-1911 Pass PYTHON variable to set-temp-creds.sh #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
approved these changes
Mar 8, 2021
| else | ||
| export PYTHON="$(pwd)/venv/bin/python" | ||
| fi | ||
|
|
There was a problem hiding this comment.
Ideally, we'd combine the virtual environment creation, python3 binary setting, and boto3 installation into a single call to activate_venv.sh.. But, that unfortunately sets PYTHON_BINARY and not PYTHON, so it wouldn't work perfectly...
There was a problem hiding this comment.
Also, PYTHON3_BINARY points to the system installation of python3, but we actually want to point to the virtualenv python installation here.
| @@ -75,8 +75,7 @@ functions: | |||
| if [ "Windows_NT" = "$OS" ]; then | |||
| mkdir -p c:/libmongocrypt/include | |||
| mkdir -p c:/libmongocrypt/bin | |||
| # TODO: After a stable libmongocrypt 1.1.0 is released in MONGOCRYPT-293, update this URL to: https://s3.amazonaws.com/mciuploads/libmongocrypt/windows/latest_release/libmongocrypt.tar.gz | |||
| curl https://s3.amazonaws.com/mciuploads/libmongocrypt/windows/latest_release/libmongocrypt_unstable.tar.gz --output libmongocrypt.tar.gz | |||
| curl https://s3.amazonaws.com/mciuploads/libmongocrypt/windows/latest_release/libmongocrypt.tar.gz --output libmongocrypt.tar.gz | |||
There was a problem hiding this comment.
Nice, looks like there was a TODO all along.
iwysiu
approved these changes
Mar 8, 2021
divjotarora
pushed a commit
that referenced
this pull request
Mar 8, 2021
This commit addresses two failures that started showing up after GODRIVER-1855: - Set the PYTHON environment variable to point to the local python3 installation before calling set-temp-creds.sh - For Windows tasks, update the libmongocrypt URL to install the latest stable version (v1.2.0)
This was referenced Mar 10, 2021
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 15, 2021
Closed
Merged
Closed
Merged
Closed
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
This commit addresses two failures that started showing up after GODRIVER-1855: - Set the PYTHON environment variable to point to the local python3 installation before calling set-temp-creds.sh - For Windows tasks, update the libmongocrypt URL to install the latest stable version (v1.2.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.