GODRIVER-1806 Fix and test DownloadStream.Skip() #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kevinAlbs
commented
Jan 5, 2021
kevinAlbs
commented
- Fix bug when skip lands on chunk boundary
- Fix bug when skip lands on chunk boundary
kevinAlbs
changed the title
kevinAlbs
force-pushed
the
gridfs.GODRIVER-1806
branch
from
e8163d5
to
4787346
Compare
|
I believe the test failures of |
kevinAlbs
commented
Jan 5, 2021
| @@ -193,29 +193,26 @@ func (ds *DownloadStream) Skip(skip int64) (int64, error) { | |||
| var err error | |||
|
|
|||
| for skipped < skip { | |||
| if ds.bufferStart == 0 { | |||
| if ds.bufferStart >= ds.bufferEnd { | |||
There was a problem hiding this comment.
This now more closely follows the logic of Read.
kevinAlbs
commented
Jan 5, 2021
mongo/integration/gridfs_test.go
Outdated
| "read 0, skip 0", 0, 0, 0, nil, "abc.def.ghi", | ||
| }, | ||
| { | ||
| "read 0, skip to end of chunk", 0, 4, 4, nil, "def.ghi", |
There was a problem hiding this comment.
This tests problem 2 described in the ticket.
mongo/integration/gridfs_test.go
Outdated
| "read 0, skip 1", 0, 1, 1, nil, "bc.def.ghi", | ||
| }, | ||
| { | ||
| "read 1, skip to end of chunk", 1, 3, 3, nil, "def.ghi", |
There was a problem hiding this comment.
This tests problem 1 described in the ticket.
benjirewis
reviewed
Jan 6, 2021
divjotarora
reviewed
Jan 7, 2021
divjotarora
approved these changes
Jan 7, 2021
benjirewis
approved these changes
Jan 7, 2021
iwysiu
approved these changes
Jan 14, 2021
kevinAlbs
added a commit
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.