GODRIVER-2333 Assert that Ping op succeeds initial DNS spec tests #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvasquez
requested review from
benjirewis and
matthewdale
and removed request for
matthewdale and
benjirewis
prestonvasquez
requested review from
matthewdale
and removed request for
qingyang-hu
matthewdale
reviewed
Nov 14, 2022
benjirewis
reviewed
Nov 15, 2022
benjirewis
approved these changes
Nov 15, 2022
prestonvasquez
added a commit
to prestonvasquez/mongo-go-driver
that referenced
this pull request
Dec 8, 2022
prestonvasquez
added a commit
that referenced
this pull request
Dec 8, 2022
* GODRIVER-2651 Break NoWritesPerformed-Only Error Sequence (#1135) Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com> Co-authored-by: Benjamin Rewis <32186188+benjirewis@users.noreply.github.com> Co-authored-by: Kevin Albertson <kevin.albertson@mongodb.com> Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com> Co-authored-by: Benjamin Rewis <32186188+benjirewis@users.noreply.github.com> * GODRIVER-2333 Assert that Ping op succeeds initial DNS spec tests (#1124) * GODRIVER-2577 Retry heartbeat on timeout to prevent pool cleanup in FAAS pause. (#1133) * resolve merge conflicts Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com> Co-authored-by: Benjamin Rewis <32186188+benjirewis@users.noreply.github.com> Co-authored-by: Kevin Albertson <kevin.albertson@mongodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2333
Summary
Sync mongo/specifications b2e35cb to
Background & Motivation
This addition will potentially expose spec test misconfigurations by running an operation on the server defined by the test connection string, rather than simply listing hosts.