GODRIVER-2565 Abort transaction before CommitLoop if context errored. #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
commented
Oct 25, 2022
| @@ -416,7 +450,7 @@ func TestConvenientTransactions(t *testing.T) { | |||
| assert.True(t, ok, "expected result type %T, got %T", false, res) | |||
| assert.False(t, resBool, "expected result false, got %v", resBool) | |||
| }) | |||
| t.Run("expired context before commitTransaction does not retry", func(t *testing.T) { | |||
| t.Run("expired context before callback does not retry", func(t *testing.T) { | |||
There was a problem hiding this comment.
These tests were inaccurately named.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2565
Summary
If the context has errored right before the
CommitLoopinWithTransaction, runAbortTransactionand return the context error.Background & Motivation
This behavior is not specified in the convenient transactions API, as it has to do with contexts (see DRIVERS-2471). If the context has errored after the callback but before
CommitLoop, there is no chance the transaction commit will succeed, and resources will be left open server-side. We should runAbortTransactionin this case as a best effort to clean up server-side.