Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GODRIVER-2174 Bump minimum Go version to 1.13. #1100

Merged
merged 7 commits into from Oct 26, 2022
Merged

GODRIVER-2174 Bump minimum Go version to 1.13. #1100

merged 7 commits into from Oct 26, 2022

Conversation

benjirewis
Copy link
Contributor

@benjirewis benjirewis commented Oct 24, 2022 •
edited

GODRIVER-2174

Bumps the minimum Go version from 1.10 to 1.13.

The followup ticket GODRIVER-2603 will refactor old code that was built before we had access to 1.13.

matthewdale
matthewdale reviewed Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also set the Go version in go.mod to 1.13. That won't break anyone's build, but it may give a build/test warning to users of older Go versions (which is what we want).

README.md Outdated Show resolved Hide resolved
@benjirewis
Copy link
Contributor Author

We should also set the Go version in go.mod to 1.13. That won't break anyone's build, but it may give a build/test warning to users of older Go versions (which is what we want).

Ah I was under the assumption that would break builds. Sounds good.

@benjirewis benjirewis changed the title GODRIVER-2174 Bump minimum Go version to 1.13 in docs. GODRIVER-2174 Bump minimum Go version to 1.13. Oct 24, 2022
matthewdale
matthewdale approved these changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

matthewdale
matthewdale approved these changes Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fixes for the Go 1.13 build check. Looks good 👍

@benjirewis benjirewis merged commit 423be54 into mongodb:master Oct 26, 2022
@benjirewis benjirewis deleted the 2174 branch October 26, 2022 23:13
matthewdale added a commit to matthewdale/mongo-go-driver that referenced this pull request Nov 4, 2022
@benjirewis @matthewdale
GODRIVER-2174 Bump minimum Go version to 1.13. (mongodb#1100)
7523633 
Co-authored-by: Matt Dale <9760375+matthewdale@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdale matthewdale matthewdale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@benjirewis @matthewdale