Fix new lint failures and drop deprecated linters. #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingyang-hu
reviewed
Aug 29, 2022
mongo/options/doc.go
Outdated
| // not use this file except in compliance with the License. You may obtain | ||
| // a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| // Package options asdfasdfa. |
There was a problem hiding this comment.
You don't seriously mean asdfasdfa, do you?
There was a problem hiding this comment.
Haha, good catch. Will update to an actual description 🤦
benjirewis
approved these changes
Aug 29, 2022
| @@ -20,12 +19,10 @@ linters: | |||
| - prealloc | |||
| - revive | |||
| - staticcheck | |||
| - structcheck | |||
| - typecheck | |||
| - unused | |||
There was a problem hiding this comment.
So deadcode, structcheck and varcheck are now all a subset of unused?
There was a problem hiding this comment.
That's correct. According to the linters documentation, the unused linter replaces the unmaintained deadcode, structcheck and varcheck linters.
benjirewis
pushed a commit
that referenced
this pull request
Sep 6, 2022
benjirewis
pushed a commit
that referenced
this pull request
Nov 1, 2022
benjirewis
pushed a commit
that referenced
this pull request
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "revive" linter now requires package comments on all packages. Add package comments to all packages commonly used by external users. Ignore package comment warnings on all other packages.
As of
golangci-lintv1.49.0, the "deadcode", "structcheck", and "varcheck" linters are deprecated (replaced by "unused"), so remove them from the configuration.