Skip to content
This repository was archived by the owner on May 31, 2022. It is now read-only.

feat!: remove datatype validation code COMPASS-4550 #341

Merged
merged 1 commit into from
Jan 8, 2021
Merged

feat!: remove datatype validation code COMPASS-4550 #341

merged 1 commit into from
Jan 8, 2021
+7 −65

Conversation

addaleax
Copy link
Contributor

@addaleax addaleax commented Jan 8, 2021

See COMPASS-4550

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

mongodb-js/compass-connect#247

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Sorry, something went wrong.

@addaleax addaleax mentioned this pull request Jan 8, 2021
Merged
10 tasks
mcasimir
mcasimir reviewed Jan 8, 2021
View reviewed changes
@mcasimir
Copy link
Contributor

mcasimir commented Jan 8, 2021 •
edited
Loading

A super very non-important al all observation: technically this kind of work should not be marked as chore since it has an impact on the production behaviour, is probably a fix or a feat.

@addaleax addaleax changed the title chore!: remove datatype validation code COMPASS-4550 feat!: remove datatype validation code COMPASS-4550 Jan 8, 2021
@addaleax addaleax merged commit 639943b into master Jan 8, 2021
@addaleax addaleax deleted the 4550-dev branch January 8, 2021 12:41
addaleax added a commit to mongodb-js/compass that referenced this pull request Jan 8, 2021
@addaleax
feat(compass-connect): move port validation to UI COMPASS-4550
cd7fb92 
→ https://jira.mongodb.org/browse/COMPASS-4550
→ mongodb-js/connection-model#341
→ mongodb-js/compass-connect#247
@addaleax addaleax mentioned this pull request Jan 8, 2021
Merged
10 tasks
addaleax added a commit to mongodb-js/compass that referenced this pull request Jan 8, 2021
@addaleax
feat(compass-connect): move port validation to UI COMPASS-4550 (#2093)
2deb992 
→ https://jira.mongodb.org/browse/COMPASS-4550
→ mongodb-js/connection-model#341
→ mongodb-js/compass-connect#247
@rose-m rose-m mentioned this pull request Jan 12, 2021
Merged
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcasimir mcasimir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@addaleax @mcasimir