Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The text styles from subtitles does not works #459

Closed
ghost opened this issue Apr 3, 2023 · 5 comments
Closed

The text styles from subtitles does not works #459

ghost opened this issue Apr 3, 2023 · 5 comments
Labels

Comments

@ghost
Copy link

ghost commented Apr 3, 2023

This player always uses custom text styles, even the subtitles with text styles.
I suggest that default to use the text style from subtitles, and add an option to force custom text styles.

@moneytoo
Copy link
Owner

moneytoo commented Apr 3, 2023

https://github.com/moneytoo/Player#how-do-i-change-subtitle-font-size-or-color

If you want to apply additional formatting defined in subtitles, leave this option off.

@ghost
Copy link
Author

ghost commented Apr 3, 2023

Thanks. But some param from subtitles does not work, like fontname, even if the video file with the font attachment.

@moneytoo
Copy link
Owner

moneytoo commented Apr 3, 2023

What subtitle format is that? In case of SSA the support is quite limited: google/ExoPlayer#8435 (comment)

@ghost
Copy link
Author

ghost commented Apr 3, 2023

ASS subtitles and TTF font in MKV file

Part of reporting from MediaInfo

General
Format                         : Matroska
Attachments                    : jf-openhuninn-1.1.a.ttf

Text
Format                         : ASS
Codec ID                       : S_TEXT/ASS
Codec ID/Info                  : Advanced Sub Station Alpha

This font not installed on the system, it only inside the mkv file.
I am sure the font name is correct, because that works in other player, like VLC.

@moneytoo
Copy link
Owner

In this case it's indeed limited by the support of ExoPlayer/Media3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant