Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permanently disable Dolby Vision and fallback to HDR. #392

Closed
vegedb opened this issue Nov 21, 2022 · 3 comments
Closed

Permanently disable Dolby Vision and fallback to HDR. #392

vegedb opened this issue Nov 21, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@vegedb
Copy link

vegedb commented Nov 21, 2022

Since there's barely any Dolby Vision android/androidtv devices, I suggest to disable it in the app rather than waiting for exoplayer to fix it.

According to this, google/ExoPlayer#9794,
if (format.sampleMimeType.equals(MimeTypes.VIDEO_DOLBY_VISION) && want_to_disable_dv)

DV can be disabled by editing a few lines and rebuilt.

Hope you can make another beta version of your app with the edited exoplayer for the time being for us. Don't think exoplayer will have an update anytime soon as its been more than a year since the issue.

@moneytoo
Copy link
Owner

Release v0.125 includes ExoPlayer r2.18.2 which has some DV related improvements so you might want to check that out.

@vegedb
Copy link
Author

vegedb commented Nov 24, 2022

Release v0.125 includes ExoPlayer r2.18.2 which has some DV related improvements so you might want to check that out.

That's a negative. Tested multiple DV videos, it still has black screen problems.

Any chance you could permanently disable it. DV is not supported in most android devices so it makes most sense I feel.

I've tried all video players, mxplayer, vlc, mpv, kodi, you name it. Just Player is the smoothest there is out there, its soooo close to be the perfect holy grail android player. Hope you would consider disabling the bane of DV for us.

@moneytoo
Copy link
Owner

Duplicate of #270. Is this about DV profile 7 or some other profile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants