fix: Run on_page_markdown event "first" #130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
on_page_markdown
so that it runs before the events from other plugins (as described on mkdocs/mkdocs#2973).Extra context
After upgrading to
mkdocs==1.4.0
andmkdocs-include-markdown-plugin==3.9.0
, I started having the following errors when building my site:This is because another plugin that I'm using,
mkdocs-macros-plugin==0.7.0
, fails to parse the mkdocs-include-markdown-plugin syntax in the Markdown pages.In practice, the mkdocs-include-markdown-plugin should be one of the very first plugins to run so that the subsequent plugins work on top of the Markdown that already has the included content, as described on the README.