Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES5 support is broken with the addition of const in 2.29.2 #5996

Closed
jamesf91 opened this issue Apr 13, 2022 · 2 comments
Closed

ES5 support is broken with the addition of const in 2.29.2 #5996

jamesf91 opened this issue Apr 13, 2022 · 2 comments

Comments

@jamesf91
Copy link

Version 2.29.2 of Moment,JS introduced a few const keywords in locale.js which has broken ES5 support for older browsers (e.g. IE11).

Would it be possible to revert these "const" to "var" to retain ES5 support?
@theboolean
Copy link
Contributor

Hi @jamesf91, I already opened a PR for this issue: #5995

@ichernev
Copy link
Contributor

Fixed in 2.29.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ichernev @theboolean @jamesf91