Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[locale] fi: fix ss not returning the number of seconds #5595

Merged
merged 2 commits into from Jun 17, 2020

Conversation

Hietamaki
Copy link
Contributor

@bleadof

The fix can probably be understood without understanding the language but mentioning author as per the CONTRIBUTING.md

@bleadof

The fix can probably be understood without understanding the language but mentioning author as per the CONTRIBUTING.md
@coveralls
Copy link

coveralls commented Jun 13, 2020

Coverage Status

Coverage decreased (-0.02%) to 88.502% when pulling ee00e33 on Hietamaki:patch-1 into 528ac2b on moment:develop.

@marwahaha
Copy link
Member

@Hietamaki thank you. could you add a test that documents this change? (For example, write a test that fails with the current moment code but passes with this change.)

@Hietamaki
Copy link
Contributor Author

I now added the unit test, but I noticed inconsistency in the ss threshold behavior compared to other thresholds. The documentation says "least number of seconds to be considered seconds" but the actual behavior is "least number of seconds + 1 to be considered seconds". So I made the test to accommodate the current behavior but either the ss threshold needs to be fixed to stay consistent with the behavior of other thresholds or the documentation needs to be changed: https://momentjs.com/docs/#/customization/relative-time-threshold/

@marwahaha
Copy link
Member

Thanks, I'll update the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants