Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Get TS tests working on Windows with cross-env #5519

Merged
merged 2 commits into from May 20, 2020

Conversation

Alanscut
Copy link
Contributor

@Alanscut Alanscut commented May 8, 2020

Changes

  • Import cross env, Fix errors reported by ts3.1-typescript-test and typescript test running on windows
  • Working well on windows and Mac.

command_bug

@coveralls
Copy link

coveralls commented May 8, 2020

Coverage Status

Coverage remained the same at 88.485% when pulling 93e49c5 on Alanscut:issue_command into 4d0f390 on moment:develop.

@Alanscut Alanscut changed the title Import cross-env library to work on Windows as well [bugfix]Import cross-env library to work on Windows as well May 11, 2020
@marwahaha marwahaha changed the title [bugfix]Import cross-env library to work on Windows as well [bugfix] Import cross-env library to work on Windows as well May 19, 2020
@marwahaha
Copy link
Member

@Alanscut Why do the typing tests fail on Windows?
I would prefer not to add an additional library, even as a devDep, but I also notice you are really contributing to this library. Thank you for that! If this is something you need for you to be a developer, let's add it.

@Alanscut
Copy link
Contributor Author

@marwahaha As far as windows developer are concerned, it is necessary, otherwise executing npm run test will give an error.

Error information

node_modules\typescript\bin\tsc" is not recognized as an internal or external command, operable program or batch file
https://stackoverflow.com/questions/43430760/unable-to-compile-typescript#
https://stackoverflow.com/questions/37585966/node-modules-bin-package-cmd-file-in-node-js/44468968#44468968

New solutions

Add nyc to the command line, but I have not verified it on mac, what do you think?

"ts3.1-typescript-test": "nyc --reporter=none node_modules/typescript3/bin/tsc --project ts3.1-typing-tests",
"typescript-test": "nyc --reporter=none node_modules/typescript/bin/tsc --project typing-tests",

@marwahaha
Copy link
Member

I'm ok with cross-env !
Please resolve the conflicts and we can include this.

@marwahaha marwahaha changed the title [bugfix] Import cross-env library to work on Windows as well [tests] Get TS tests working on Windows with cross-env May 20, 2020
@marwahaha marwahaha added todo and removed Discussion labels May 20, 2020
@Alanscut
Copy link
Contributor Author

Alanscut commented May 20, 2020

@marwahaha Conflict resolved, thanks 😄 .

@marwahaha marwahaha removed the todo label May 20, 2020
@marwahaha marwahaha merged commit 6152124 into moment:develop May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants