[locale] Fix Indian week start date and week number #5502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumarharsh
changed the title
kumarharsh
changed the title
|
I'm not an expert with the CLDR standard, but I think that makes sense. Thank you @kumarharsh for your repeated contributions to this library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ichernev - following the directions in previous PR, I'm updating the en-in locale.
The Indian week starts on a Sunday, and 1st January is the first day of the week. This is the most official source I could find:
https://unicode-org.github.io/cldr-staging/charts/37/supplemental/territory_information.html#IN
If I understand the "Days in week (min)" column, the value of 1 would also mean that the first week would start on 1st Jan, even if it's a Saturday. Am I correct?