Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[locale] ja: Define the last day of 'Heisei' Era #5476

Conversation

eternalharvest
Copy link
Contributor

Abstract

As @ichernev is mentioned in PR#5471, the until definition is missing.
So, I wrote this PR to fix this.

This patch just define the last day of 'Heisei' Era in Japanese locale.
Though the result itself is not changed.

@coveralls
Copy link

coveralls commented Apr 30, 2020

Coverage Status

Coverage increased (+0.03%) to 88.495% when pulling bc91bc8 on eternalharvest:feature/define_the_last_day_of_Heisei_Era into d8e613b on moment:develop.

@eternalharvest eternalharvest force-pushed the feature/define_the_last_day_of_Heisei_Era branch from c702a65 to bc91bc8 Compare April 30, 2020 10:12
@eternalharvest eternalharvest changed the title [locale] ja; Define the last day of 'Heisei' Era [locale] ja: Define the last day of 'Heisei' Era Apr 30, 2020
@ichernev ichernev merged commit f98d5a2 into moment:develop Apr 30, 2020
@eternalharvest eternalharvest deleted the feature/define_the_last_day_of_Heisei_Era branch May 1, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants