[locale] br: Add meridiem translation and correct quotemark

[o-Chamie-o]

eur e brezhoneg Lizherennañ

Mat eo g.m. evit PM (goude merenn) ha a.m. evit AM (a-raok merenn).

--
Should be g.m. for PM, stand for goude merenn and a.m. for AM stand for a-raok Merenn

Here some sources :
http://www.brezhoneg.bzh/177-divizou-hag-erbedadennou-ar-chuzul-skiantel.htm
https://www.unicode.org/cldr/charts/latest/summary/br.html

[coveralls]

Coverage increased (+0.007%) to 88.492% when pulling 7373dbf on o-Chamie-o:patch-2 into 04b275c on moment:develop.

[ichernev]

@jbleduigou can you comment on this please.

@o-Chamie-o it would help if you speak english :)

[jbleduigou]

Hi,

Thanks for contributing!

We actually moved away from the 12 hour notation.
See this PR: #4975

I don't know if it has been actually released?

[o-Chamie-o]

it would help if you speak english :)

All translated on my comment. :) @ichernev

Hum strange choice, @jbleduigou as I mentioned, the Unicode recommandation and the one from the OPAB are 12 based.

I can double check this maybe ? 🤔

[jbleduigou]

Hum strange choice, @jbleduigou as I mentioned, the Unicode recommandation and the one from the OPAB are 12 based.

I can double check this maybe ? 🤔

I actually don't have strong opinions on this one.
It might make more sense to use 12 hours.

[ichernev]

@o-Chamie-o about the other changes -- they mostly revolve around this quote. Do people use these special characters when they type? If not then parsing will be completely broken (for reading in dates from user input).

[o-Chamie-o]

I true that, the parsing will be broken. :( As on the keyboard the single quote is used instead of the apostrophe.

Can we add option in the parser ? For both single quote and apostrophe maybe ?

In order to display it right. :)

[o-Chamie-o]

This should do the trick right ? @ichernev

var monthsParse = [/^genver/i, /^c[ʼ\']hwevrer/i, /^meurzh/i, /^ebrel/i, /^mae/i, /^mezheven\/i, /^gouere/i, /^eost/i, /^gwengolo/i, /^here/i, /^du/i, /^kerzu/i];
var monthsShortParse = [/^gen/i, /^c[ʼ\']hwe/i, /^meu/i, /^ebr/i, /^mae/i, /^eve\/i, /^gou/i, /^eos/i, /^gwe/i, /^her/i, /^du/i, /^ker/i];
var weekdaysParse = [/^sul/i, /^lun/i, /^meurzh/i, /^merc[ʼ\']her/i, /^yaou/i, /^gwener\/i, /^sadorn/i,];
...
monthsParse : monthsParse,
monthsShortParse : monthsShortParse,
weekdaysParse  : weekdaysParse ,

Other advantage, we now support case incensitive case. ;)

[ichernev]

@o-Chamie-o well, yes. If we don't want to break existing code the parsing regexes should be more lenient.

Also make sure to add tests for parsing with different quote. Esp important if any names contain spaces (I think this is not the case for this locale, but still).

[jbleduigou]

Hi,
Sorry for the delay, I have been fairly busy lately and didn't get a chance to review this PR.
I went through the links you provided.

Using a.m. and p.m. was definitely wrong.
Switching to 24 hours notation was an okay workaround.
But ultimately I believe that your suggestion with a.m and g.m. is better.

Thanks for contributing!

[o-Chamie-o]

No worries @jbleduigou :)

Thanks to you for the BR locale support in the first place. :)

[marwahaha]

@o-Chamie-o glad to hear you have approval from the locale author.
Could you please update with the latest code on develop branch and resolve conflicts?
If you need help with this let me know.
Then we can merge it!

[o-Chamie-o]

Arf some issues with the month parsing. :(

[marwahaha]

Oh no :( hope you can get it fixed!

[o-Chamie-o]

🙏 Thanks a bunch @marwahaha
Mersi bras dit. :)